[Android] Fixed Material controls themeing issue by NirmalKumarYuvaraj · Pull Request #30415 · dotnet/maui

NirmalKumarYuvaraj · 2025-07-03T12:00:20Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root cause

The problem is that the MauiMaterialButton style has a parent of Widget.MaterialComponents.Button.UnelevatedButton, which requires the application theme to be based on Theme.MaterialComponents. However, the MauiMaterialButton constructor is wrapping the context with just the button style, not ensuring the proper theme hierarchy.

Description of change

This pull request addresses an issue where certain Material components on Android require a specific app theme (Theme.MaterialComponent) to avoid runtime exceptions. It introduces a new MauiMaterialContextThemeWrapper to ensure the correct theme is applied to Material components and adds test cases to validate the changes.

Fix for Material Component Theme Issue:

src/Core/src/Platform/Android/MauiMaterialContextThemeWrapper.cs: Added MauiMaterialContextThemeWrapper class to wrap the Android context with the appropriate Material theme (Resource.Style.Maui_MainTheme_Base). This ensures Material components use the correct theme.
src/Core/src/Handlers/CheckBox/CheckBoxHandler.Android.cs : Updated CheckBoxHandler to use MauiMaterialContextThemeWrapper.Create(Context) when creating MaterialCheckBox, ensuring the correct theme is applied.
src/Core/src/Platform/Android/MauiMaterialButton.cs : Modified MauiMaterialButton to use MauiMaterialContextThemeWrapper.Create(context) for all constructors, ensuring consistent theme application for Material buttons.

Reference

maui/src/Compatibility/Material/src/Android/MaterialButtonRenderer.cs

Lines 42 to 43 in aac6557

    
           public MaterialButtonRenderer(Context context) 
        
           	: this(MaterialContextThemeWrapper.Create(context), null) { }

https://github.com/dotnet/maui/blob/main/src/Compatibility/Material/src/Android/MaterialContextThemeWrapper.cs

Validated the behaviour in the following platforms

Android
Windows
iOS
Mac

Issues Fixed

Fixes #13356

Output

Before	After
	After.mov

Copilot

Pull Request Overview

This PR ensures that Android Material controls are themed correctly by introducing a context wrapper, updating handlers to use it, and adding repro tests.

Added a MauiMaterialContextThemeWrapper to wrap Android contexts with the Material theme.
Updated MauiMaterialButton and CheckBoxHandler.Android to use the new theme wrapper.
Added a HostApp sample page and corresponding UI tests to validate the fix for Issue #13356.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Core/src/Platform/Android/MauiMaterialContextThemeWrapper.cs	New wrapper class to apply the correct Material theme to Android views.
src/Core/src/Platform/Android/MauiMaterialButton.cs	Updated button constructors to use `MauiMaterialContextThemeWrapper`.
src/Core/src/Handlers/CheckBox/CheckBoxHandler.Android.cs	Updated `MaterialCheckBox` instantiation to use the theme wrapper.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue13356.cs	Added UITests for Material button and checkbox dialogs on Android.
src/Controls/tests/TestCases.HostApp/Issues/Issue13356.cs	Added HostApp sample page and dialog implementation for Issue #13356.

Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.HostApp/Issues/Issue13356.cs:45

The dialog's Button is missing an AutomationId, so the test WaitForElement("Dialog Button") may not locate it. Consider setting an AutomationId on this Button (e.g., AutomationId = "DialogButton") to match the test or update the test to query by text explicitly.

			Content = new Button { Text = "Dialog Button", Padding = new Thickness(30) }

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue13356.cs

jsuarezruiz · 2025-10-27T15:42:42Z

src/Core/src/Platform/Android/MauiMaterialContextThemeWrapper.cs

+
+namespace Microsoft.Maui.Platform;
+
+internal class MauiMaterialContextThemeWrapper : ContextThemeWrapper


Each call wraps the context in a new ContextThemeWrapper. This is lightweight but worth monitoring if frequently recreated during inflation.

* Fixed Exception * Optimized code * Updated fix * fixed checkbox * enabled android test * Fixed typo

NirmalKumarYuvaraj added 4 commits July 2, 2025 17:48

Fixed Exception

e3b302b

Optimized code

c1e4fc1

Updated fix

74741ef

fixed checkbox

241bc73

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jul 3, 2025

jsuarezruiz added the platform/android label Jul 3, 2025

enabled android test

688e7ad

NirmalKumarYuvaraj marked this pull request as ready for review July 4, 2025 07:46

Copilot AI review requested due to automatic review settings July 4, 2025 07:46

NirmalKumarYuvaraj requested a review from a team as a code owner July 4, 2025 07:46

NirmalKumarYuvaraj requested review from mattleibow and rmarinho July 4, 2025 07:46

Copilot AI reviewed Jul 4, 2025

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue13356.cs Outdated Show resolved Hide resolved

Fixed typo

f017ffe

jsuarezruiz approved these changes Oct 27, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current October 31, 2025 20:29

PureWeen merged commit fa25606 into dotnet:inflight/current Oct 31, 2025
2 checks passed

PureWeen pushed a commit that referenced this pull request Nov 11, 2025

[Android] Fixed Material controls themeing issue (#30415)

9b42c2d

* Fixed Exception * Optimized code * Updated fix * fixed checkbox * enabled android test * Fixed typo

github-actions bot pushed a commit that referenced this pull request Nov 11, 2025

[Android] Fixed Material controls themeing issue (#30415)

ba14e5b

* Fixed Exception * Optimized code * Updated fix * fixed checkbox * enabled android test * Fixed typo

github-actions bot pushed a commit that referenced this pull request Nov 14, 2025

[Android] Fixed Material controls themeing issue (#30415)

5086ba2

* Fixed Exception * Optimized code * Updated fix * fixed checkbox * enabled android test * Fixed typo

github-actions bot pushed a commit that referenced this pull request Nov 15, 2025

[Android] Fixed Material controls themeing issue (#30415)

2b28dc1

* Fixed Exception * Optimized code * Updated fix * fixed checkbox * enabled android test * Fixed typo

github-actions bot pushed a commit that referenced this pull request Nov 15, 2025

[Android] Fixed Material controls themeing issue (#30415)

8bc9438

* Fixed Exception * Optimized code * Updated fix * fixed checkbox * enabled android test * Fixed typo

github-actions bot pushed a commit that referenced this pull request Nov 18, 2025

[Android] Fixed Material controls themeing issue (#30415)

f516be2

* Fixed Exception * Optimized code * Updated fix * fixed checkbox * enabled android test * Fixed typo

github-actions bot pushed a commit that referenced this pull request Nov 18, 2025

[Android] Fixed Material controls themeing issue (#30415)

2e1e288

* Fixed Exception * Optimized code * Updated fix * fixed checkbox * enabled android test * Fixed typo

github-actions bot pushed a commit that referenced this pull request Nov 18, 2025

[Android] Fixed Material controls themeing issue (#30415)

cc433c1

* Fixed Exception * Optimized code * Updated fix * fixed checkbox * enabled android test * Fixed typo

github-actions bot pushed a commit that referenced this pull request Nov 20, 2025

[Android] Fixed Material controls themeing issue (#30415)

33cafb8

* Fixed Exception * Optimized code * Updated fix * fixed checkbox * enabled android test * Fixed typo

github-actions bot pushed a commit that referenced this pull request Nov 20, 2025

[Android] Fixed Material controls themeing issue (#30415)

7a27715

* Fixed Exception * Optimized code * Updated fix * fixed checkbox * enabled android test * Fixed typo

github-actions bot locked and limited conversation to collaborators Dec 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] Fixed Material controls themeing issue#30415

[Android] Fixed Material controls themeing issue#30415
PureWeen merged 6 commits intodotnet:inflight/currentfrom
NirmalKumarYuvaraj:fix-13356

NirmalKumarYuvaraj commented Jul 3, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

jsuarezruiz Oct 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	public MaterialButtonRenderer(Context context)
	: this(MaterialContextThemeWrapper.Create(context), null) { }


		namespace Microsoft.Maui.Platform;

		internal class MauiMaterialContextThemeWrapper : ContextThemeWrapper

Conversation

NirmalKumarYuvaraj commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root cause

Description of change

Fix for Material Component Theme Issue:

Reference

Issues Fixed

Output

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

jsuarezruiz Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NirmalKumarYuvaraj commented Jul 3, 2025 •

edited

Loading